Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Release permits and reopen the refresh listeners & RemoteFsTranslog if the primary relocation fails #11323

Closed
ashking94 opened this issue Nov 24, 2023 · 3 comments
Assignees
Labels
Storage:Durability Issues and PRs related to the durability framework Storage:Remote v2.12.0 Issues and PRs related to version 2.12.0

Comments

@ashking94
Copy link
Member

ashking94 commented Nov 24, 2023

Is your feature request related to a problem? Please describe.
We acquire all permits of Refresh Listeners and close them during the primary relocation. However, it is possible that the handoff does not succeed and the old primary continues to be primary still. In such cases, we want that the segments and translog to continue getting uploaded to remote store.

Describe the solution you'd like
Release permits and allow running refreshes and translog uploads back again. The old primary should be capable to upload segments and translog if the handoff was to fail and the old primary is still the acting primary.

Describe alternatives you've considered
None

Additional context
None

@ashking94 ashking94 added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework Storage:Remote labels Nov 24, 2023
@ashking94 ashking94 self-assigned this Nov 24, 2023
@ashking94 ashking94 added v2.12.0 Issues and PRs related to version 2.12.0 and removed untriaged labels Nov 24, 2023
@sachinpkale
Copy link
Member

This is not a bug today as we do not hold translog permits during relocation handoff and segment permits are not held due to this bug.

@ashking94 ashking94 removed the bug Something isn't working label Nov 25, 2023
@ashking94 ashking94 changed the title [BUG] Release permits and reopen the refresh listeners & RemoteFsTranslog if the primary relocation fails [Remote Store] Release permits and reopen the refresh listeners & RemoteFsTranslog if the primary relocation fails Nov 25, 2023
@kiranprakash154
Copy link
Contributor

Hi, are we on track for this to be released in 2.12 ?

@ashking94
Copy link
Member Author

This is done and there are issues mentioned already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage:Durability Issues and PRs related to the durability framework Storage:Remote v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants