Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReleasableLock within Engine and Translog related classes #11360

Open
ashking94 opened this issue Nov 28, 2023 · 2 comments
Open

Use ReleasableLock within Engine and Translog related classes #11360

ashking94 opened this issue Nov 28, 2023 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Storage:Durability Issues and PRs related to the durability framework

Comments

@ashking94
Copy link
Member

Is your feature request related to a problem? Please describe.
Follow of #11330 (comment)

Describe the solution you'd like
Replace sempahore with ReleasableLock

@macohen
Copy link
Contributor

macohen commented Nov 30, 2023

@ashking94 can you please give a little more background in this issue with why ReleasableLock should replace semaphore? It will help to provide some more context here to categorize and help make it more findable for the community. Thanks!

@macohen macohen added Storage:Durability Issues and PRs related to the durability framework and removed untriaged labels Nov 30, 2023
@ashking94
Copy link
Member Author

@ashking94 can you please give a little more background in this issue with why ReleasableLock should replace semaphore? It will help to provide some more context here to categorize and help make it more findable for the community. Thanks!

There was comment here about this which you can refer. We already use releasable locks at multiple places in our Engine, Translog and other core classes. We have introduced usage of semaphore for the same purpose (as releasable locks) at multiple places. This is mostly a nitpick task - to ensure that we are using similar constructs and standards (i.e. releasable locks instead of semaphores) across these classes.

@ashking94 ashking94 added the good first issue Good for newcomers label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Storage:Durability Issues and PRs related to the durability framework
Projects
Status: Ready To Be Picked
Development

No branches or pull requests

2 participants