Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Feature Flag Archival #12150

Open
jed326 opened this issue Feb 2, 2024 · 3 comments
Open

[Feature Request] Support Feature Flag Archival #12150

jed326 opened this issue Feb 2, 2024 · 3 comments
Labels
enhancement Enhancement or improvement to existing feature or request Other

Comments

@jed326
Copy link
Collaborator

jed326 commented Feb 2, 2024

Is your feature request related to a problem? Please describe

Today there is no concept of feature flag archival. This means that when a feature flag is removed, existing clusters that are using the feature flag will run into problems when trying to upgrade to the new software version without the feature flag.

See: #12074 (comment)

Describe the solution you'd like

We should have something like 68d07fc to support archival of old feature flags. Moreover, we should print some sort of deprecation message when old feature flags are found.

Related component

Other

Describe alternatives you've considered

No response

Additional context

No response

@jed326 jed326 added enhancement Enhancement or improvement to existing feature or request untriaged labels Feb 2, 2024
@github-actions github-actions bot added the Other label Feb 2, 2024
@jed326
Copy link
Collaborator Author

jed326 commented Feb 2, 2024

Some more things to think about

  1. What would we do if we need to change the name of an experimental feature?
  2. How add a test to cover this?
  3. Can we generalize this to all static settings instead of just feature flags?

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4]
@jed326 Thanks for filing, looking forward to PRs that address this

@jed326
Copy link
Collaborator Author

jed326 commented May 27, 2024

Example of renaming feature flag: #13799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Other
Projects
None yet
Development

No branches or pull requests

2 participants