Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Reindex] Add support for configurable retries in remote reindex process #12560

Closed
ankitkala opened this issue Mar 8, 2024 · 1 comment · Fixed by #12561
Closed

[Remote Reindex] Add support for configurable retries in remote reindex process #12560

ankitkala opened this issue Mar 8, 2024 · 1 comment · Fixed by #12561
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing

Comments

@ankitkala
Copy link
Member

Is your feature request related to a problem? Please describe

  • Current implementation retries the reindex process from the start which isn't ideal as we end up again fetching all the documents which were ingested in last attempt.
  • Retries are only done for 429s as of now. If the remote cluster is overwhelmed, we should backoff and retry.
  • Debugging is harder due to lack of logs at certain methods. Also, logs from multiple ongoing reindexes are hard to segregate.

Describe the solution you'd like

  • Change the behavior of retry logic to scroll requests to remote cluster.
  • Add retries for 5xx & ConnectException.
  • Expose the retry params behind cluster settings.
  • Changed the logger to prefix based. This is useful to segregate logs from multiple ongoing reindexes for easier debugging.
  • Add additional debug logs for ease of tracking the reindex operation.

Related component

Indexing

Describe alternatives you've considered

No response

Additional context

No response

@ankitkala ankitkala added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 8, 2024
@ankitkala ankitkala self-assigned this Mar 8, 2024
@github-actions github-actions bot added the Indexing Indexing, Bulk Indexing and anything related to indexing label Mar 8, 2024
@ankitkala
Copy link
Member Author

Issue for adding documentation: opensearch-project/documentation-website#6674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant