Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMOVE] Cleanup deprecated thread pool settings #2595

Closed
reta opened this issue Mar 25, 2022 · 5 comments · Fixed by #3352
Closed

[REMOVE] Cleanup deprecated thread pool settings #2595

reta opened this issue Mar 25, 2022 · 5 comments · Fixed by #3352
Labels
>breaking Identifies a breaking change. enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0

Comments

@reta
Copy link
Collaborator

reta commented Mar 25, 2022

Is your feature request related to a problem? Please describe.
Right now some of the thread pool settings are declared as deprecated and logged by deprecation logger:

[2022-03-25T16:00:21,595][DEPRECATION][o.o.d.c.s.Settings       ] [testSetLowerSettings] [thread_pool.test.max_queue_size] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
[2022-03-25T16:00:21,596][DEPRECATION][o.o.d.c.s.Settings       ] [testSetLowerSettings] [thread_pool.test.min_queue_size] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.

Describe the solution you'd like
Cleanup deprecated thread pool settings in 3.0.0

Describe alternatives you've considered
Leave them there

Additional context
N/A

@reta reta added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 25, 2022
@reta
Copy link
Collaborator Author

reta commented Mar 25, 2022

@nknize @andrross do you guys know what is the plan for those? thanks!

@andrross
Copy link
Member

It looks like the AutoQueueAdjustingExecutorBuilder itself was deprecated for removal due to being experimental and not being used. Seems like we can go ahead and take it out unless anyone has objections.

@andrross andrross added v2.1.0 Issues and PRs related to version 2.1.0 and removed untriaged labels Mar 28, 2022
@andrross
Copy link
Member

I don't think we need to get this change into the upcoming 2.0 release, but we can target it for 2.1.

@reta
Copy link
Collaborator Author

reta commented Mar 28, 2022

It will be breaking change, right? So next major like 3.0.0?

@andrross
Copy link
Member

It will be breaking change, right? So next major like 3.0.0?

Of course, you're right, since there are configuration settings to remove. I still think we can pass on 2.0 since that is coming up rapidly and this doesn't seem critical. We can target 3.0 instead.

@andrross andrross added v3.0.0 Issues and PRs related to version 3.0.0 >breaking Identifies a breaking change. and removed v2.1.0 Issues and PRs related to version 2.1.0 labels Mar 29, 2022
@reta reta changed the title [FEATURE] Cleanup deprecated thread pool settings [REMOVE] Cleanup deprecated thread pool settings May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants