Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese and Korean language analyzers #3950

Closed
macrakis opened this issue Jul 19, 2022 · 4 comments
Closed

Update Japanese and Korean language analyzers #3950

macrakis opened this issue Jul 19, 2022 · 4 comments
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request

Comments

@macrakis
Copy link

Is your feature request related to a problem? Please describe.
The current Japanese (kuromoji) and Korean (seunjeon) language analyzers / tokenizers are out of date.

Describe the solution you'd like
Update to the latest versions.

@macrakis macrakis added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 19, 2022
@minalsha
Copy link
Contributor

@macrakis what exactly is out of date and could you please share some additional details to help us investigate?

@dbwiddis
Copy link
Member

dbwiddis commented Jul 26, 2022

Looks like the versions are tied to the Lucene dependency version:

api "org.apache.lucene:lucene-analysis-kuromoji:${versions.lucene}"

api "org.apache.lucene:lucene-analysis-nori:${versions.lucene}"

Currently kuromoji is on 9.1.0 (#2487) and nori is on 9.0.0 (#1109) but neither was included in the 9.3.0 update (#3537).

@dbwiddis
Copy link
Member

Actually, those were the latest code changes, but the dependency should have been updated with the latest Lucene version used in the build. There is no way to independently upgrade those plugins.

@minalsha
Copy link
Contributor

For OpenSearch 2.0, 2.0 we did upgrade to Lucene 9 and these dependencies@st should have been upgraded. Next steps would be to validate with customer on what version of OpenSearch they are using. @macrakis as discussed today, closing this issue but feel free to open it if you have additional information from customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

4 participants