Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify plugin cli to disable install elastic official plugins by name #71

Closed
adnapibar opened this issue Feb 9, 2021 · 2 comments · Fixed by #101
Closed

Modify plugin cli to disable install elastic official plugins by name #71

adnapibar opened this issue Feb 9, 2021 · 2 comments · Fixed by #101
Labels
>FORK Related to the fork process

Comments

@adnapibar
Copy link
Contributor

adnapibar commented Feb 9, 2021 •
edited

Currently the plugin cli allows installation of a plugin by name in which case it downloads the plugin artifacts from the official elastic repository. We need to remove disable this feature (as per Nick's comment below).

Related #100
@adnapibar adnapibar added the >FORK Related to the fork process label Feb 10, 2021
@nknize
Copy link
Collaborator

nknize commented Feb 10, 2021 •
edited

Might not want to remove it since it's OSS functionality we could reuse to download our own OSS plugins?

Could we temporarily disable until we get our own plugins converted and published to a repository?

@adnapibar
Copy link
Contributor Author

Yes that makes sense. I'll update the description to reflect that.

@adnapibar adnapibar mentioned this issue Feb 10, 2021
Closed
@adnapibar adnapibar changed the title Modify plugin cli to remove install elastic official plugins by name Modify plugin cli to ~~remove~~disable install elastic official plugins by name Feb 10, 2021
@adnapibar adnapibar changed the title Modify plugin cli to ~~remove~~disable install elastic official plugins by name Modify plugin cli to disable install elastic official plugins by name Feb 10, 2021
@adnapibar adnapibar self-assigned this Feb 11, 2021
@adnapibar adnapibar mentioned this issue Feb 14, 2021
Merged
@adnapibar adnapibar linked a pull request Feb 14, 2021 that will close this issue
Disable plugincli feature #101
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>FORK Related to the fork process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable plugincli feature
2 participants
@nknize @adnapibar