Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct copyright notices to reflect Copyright OpenSearch Contributors #161

Closed
Tracked by #21
dblock opened this issue Aug 6, 2021 · 8 comments
Closed
Tracked by #21
Assignees
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented Aug 6, 2021

Coming from opensearch-project/.github#21.

The correct copyright for open-source projects in opensearch-project is "Copyright OpenSearch Contributors". Please correct any places that say otherwise, especially where it says copyright Amazon. Make sure NOTICE.txt and README match. See opensearch-project/.github#24 for an example.

@dblock dblock added the bug Something isn't working label Aug 6, 2021
@ylwu-amzn
Copy link
Collaborator

We keep the old copyright for all class files created in ODFE, for example https://github.com/opensearch-project/anomaly-detection/blob/main/src/main/java/org/opensearch/ad/AnomalyDetectorPlugin.java#L13-L24

Should we remove this old copyright no matter if the file created in ODFE or not?
If yes, should we remove this old copyright in branch 1.0?

@ylwu-amzn
Copy link
Collaborator

How about we change the label ? bug label seems misleading

@dblock
Copy link
Member Author

dblock commented Sep 28, 2021

You do not need to keep old Amazon copyright from ODFE in the code as we're rewriting it to be OpenSearch Contributors, we had consulted legal on this.

You should make changes on main, do not backport to 1.0 (and probably no time to backport to 1.1 either).

@ylwu-amzn
Copy link
Collaborator

Got it. Sure, will remove the old Amazon copyright and merge to main branch.

@CEHENKLE
Copy link
Member

CEHENKLE commented Nov 9, 2021

@ylwu-amzn Hey, can this issue be closed? Do you think you caught everything in #257 ?

Thanks!
/C

@ylwu-amzn
Copy link
Collaborator

Kept the issue as we haven't fixed frontend package. Now frontend copyright fixed opensearch-project/anomaly-detection-dashboards-plugin#118, will close this issue.

@AMoo-Miki
Copy link

The correct header for this one is:

/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 */

@ylwu-amzn
Copy link
Collaborator

The correct header for this one is:

/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 */

Thanks @AMoo-Miki , this file anomaly-detection/src/forbidden/ad-signatures.txt is to define which copyright is wrong,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants