Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility check readiness #1028

Closed
2 tasks
gaiksaya opened this issue Jun 28, 2023 · 3 comments
Closed
2 tasks

Ensure compatibility check readiness #1028

gaiksaya opened this issue Jun 28, 2023 · 3 comments

Comments

@gaiksaya
Copy link
Member

Coming from opensearch-project/opensearch-devops#114 (comment)

Overview

In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on publishToMavenLocal task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs ./gradlew assemble.

Action Items

In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:

  • The build.gradle file in this repository uses mavenLocal() as the first entry in repositories() section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks.
  • ./gradlew assemble task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.

Please close this issue once the above checklist is complete.

Thanks!

@bbarani
Copy link
Member

bbarani commented Jul 7, 2023

@saikaranam-amazon @mohitamg can you please provide an update?

@mohitamg
Copy link
Contributor

Checked the above two Action items, the build succeeded for 2.9 branch (ran it in 2.x which is currently tracking OS 2.9.0)

./gradlew assemble                                                                                                                  ✔    05:43:32 PM
Downloading https://services.gradle.org/distributions/gradle-7.6.1-all.zip
.............................................................................................................................................................

Welcome to Gradle 7.6.1!

Here are the highlights of this release:
 - Added support for Java 19.
 - Introduced `--rerun` flag for individual task rerun.
 - Improved dependency block for test suites to be strongly typed.
 - Added a pluggable system for Java toolchains provisioning.

For more details see https://docs.gradle.org/7.6.1/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.6.1
  OS Info               : Mac OS X 13.4 (aarch64)
  JDK Version           : 18 (Amazon Corretto JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/amazon-corretto-18.jdk/Contents/Home
  Random Testing Seed   : 7AA2D779DFEDD10F
  In FIPS 140 mode      : false
=======================================

> Task :compileKotlin
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/ReplicationPlugin.kt: (264, 16): Type List<ExecutorBuilder<out ExecutorBuilder.ExecutorSettings>> is inaccessible in this context due to: public/*package*/ abstract class ExecutorSettings defined in org.opensearch.threadpool.ExecutorBuilder
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/autofollow/AutoFollowClusterManagerNodeRequest.kt: (16, 45): 'MasterNodeRequest<Request : MasterNodeRequest<Request!>!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/autofollow/AutoFollowClusterManagerNodeRequest.kt: (23, 44): 'MasterNodeRequest<Request : MasterNodeRequest<Request!>!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/autofollow/TransportAutoFollowClusterManagerNodeAction.kt: (34, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/autofollow/TransportAutoFollowClusterManagerNodeAction.kt: (52, 9): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/autofollow/TransportAutoFollowClusterManagerNodeAction.kt: (54, 96): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/autofollow/TransportUpdateAutoFollowPatternAction.kt: (42, 103): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/changes/TransportGetChangesAction.kt: (72, 9): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/ReplicateIndexClusterManagerNodeRequest.kt: (16, 45): 'MasterNodeRequest<Request : MasterNodeRequest<Request!>!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/ReplicateIndexClusterManagerNodeRequest.kt: (24, 9): 'MasterNodeRequest<Request : MasterNodeRequest<Request!>!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/TransportReplicateIndexAction.kt: (56, 23): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/TransportReplicateIndexClusterManagerNodeAction.kt: (34, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/TransportReplicateIndexClusterManagerNodeAction.kt: (65, 9): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/TransportReplicateIndexClusterManagerNodeAction.kt: (67, 27): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/block/TransportUpddateIndexBlockAction.kt: (26, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/block/TransportUpddateIndexBlockAction.kt: (47, 9): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/index/block/TransportUpddateIndexBlockAction.kt: (49, 65): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/pause/TransportPauseIndexReplicationAction.kt: (29, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/pause/TransportPauseIndexReplicationAction.kt: (53, 5): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/pause/TransportPauseIndexReplicationAction.kt: (55, 61): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/replicationstatedetails/TransportUpdateReplicationStateDetails.kt: (25, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/replicationstatedetails/TransportUpdateReplicationStateDetails.kt: (42, 9): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/replicationstatedetails/TransportUpdateReplicationStateDetails.kt: (44, 27): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/replicationstatedetails/TransportUpdateReplicationStateDetails.kt: (56, 25): Unchecked cast: UpdateReplicationStateDetailsTaskExecutor to ClusterStateTaskExecutor<AcknowledgedRequest<UpdateReplicationStateDetailsRequest>>
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/resume/TransportResumeIndexReplicationAction.kt: (43, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/resume/TransportResumeIndexReplicationAction.kt: (70, 5): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/resume/TransportResumeIndexReplicationAction.kt: (72, 61): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stats/NodeStatsRequest.kt: (14, 44): 'BaseNodeRequest' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stats/NodeStatsRequest.kt: (19, 26): 'BaseNodeRequest' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stats/TransportAutoFollowStatsAction.kt: (34, 147): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stats/TransportFollowerStatsAction.kt: (39, 75): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stats/TransportLeaderStatsAction.kt: (41, 73): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/status/TransportReplicationStatusAction.kt: (39, 27): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stop/TransportStopIndexReplicationAction.kt: (40, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stop/TransportStopIndexReplicationAction.kt: (71, 5): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/stop/TransportStopIndexReplicationAction.kt: (73, 61): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/update/TransportUpdateIndexReplicationAction.kt: (28, 45): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/update/TransportUpdateIndexReplicationAction.kt: (51, 5): 'TransportMasterNodeAction<Request : MasterNodeRequest<Request!>!, Response : ActionResponse!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/action/update/TransportUpdateIndexReplicationAction.kt: (53, 61): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/metadata/TransportUpdateMetadataAction.kt: (109, 92): 'masterNodeTimeout(): TimeValue!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/metadata/TransportUpdateMetadataAction.kt: (129, 53): 'masterNodeTimeout(): TimeValue!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/metadata/TransportUpdateMetadataAction.kt: (189, 74): 'masterNodeTimeout(): TimeValue!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/metadata/TransportUpdateMetadataAction.kt: (214, 40): 'masterNodeTimeout(): TimeValue!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/metadata/TransportUpdateMetadataAction.kt: (253, 84): 'masterNodeTimeout(): TimeValue!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/metadata/store/ReplicationMetadataStore.kt: (255, 18): 'mapping(String!, XContentType!): CreateIndexRequest!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/repository/RemoteClusterMultiChunkTransfer.kt: (53, 99): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/repository/RemoteClusterRepository.kt: (87, 147): This is a delicate API and its use requires care. Make sure you fully read and understand documentation of the declaration that is marked as a delicate API.
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/rest/UpdateIndexHandler.kt: (45, 31): 'masterNodeTimeout(TimeValue!): UpdateSettingsRequest!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/rest/UpdateIndexHandler.kt: (45, 109): 'masterNodeTimeout(): TimeValue!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/seqno/RemoteClusterRetentionLeaseHelper.kt: (105, 109): Parameter 'timeout' is never used
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/seqno/RemoteClusterTranslogService.kt: (41, 35): 'getHistoryOperationsFromTranslogFile(String!, Long, Long): Translog.Snapshot!' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/CrossClusterReplicationTask.kt: (97, 17): This declaration is experimental and its usage should be marked with '@kotlinx.coroutines.ObsoleteCoroutinesApi' or '@OptIn(kotlinx.coroutines.ObsoleteCoroutinesApi::class)'
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/autofollow/AutoFollowTask.kt: (71, 26): This declaration overrides experimental member of supertype 'CrossClusterReplicationTask' and should be annotated with '@kotlinx.coroutines.ObsoleteCoroutinesApi'
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt: (171, 33): This declaration overrides experimental member of supertype 'CrossClusterReplicationTask' and should be annotated with '@kotlinx.coroutines.ObsoleteCoroutinesApi'
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt: (313, 37): Unchecked cast: PersistentTasksCustomMetadata.PersistentTask<*>! to PersistentTasksCustomMetadata.PersistentTask<IndexReplicationParams>
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt: (318, 43): Unchecked cast: Any! to PersistentTasksCustomMetadata.PersistentTask<IndexReplicationParams>
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt: (692, 37): Unchecked cast: PersistentTasksCustomMetadata.PersistentTask<*>! to PersistentTasksCustomMetadata.PersistentTask<ShardReplicationParams>
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt: (754, 33): Unchecked cast: PersistentTasksCustomMetadata.PersistentTask<*>! to PersistentTasksCustomMetadata.PersistentTask<ShardReplicationParams>
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/util/Coroutines.kt: (23, 45): 'MasterNodeRequest<Request : MasterNodeRequest<Request!>!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/util/Coroutines.kt: (254, 18): 'MasterNodeRequest<Request : MasterNodeRequest<Request!>!>' is deprecated. Deprecated in Java
w: /Users/mohitamg/Documents/GitHub/cross-cluster-replication/src/main/kotlin/org/opensearch/replication/util/ValidationUtil.kt: (75, 18): 'toLowerCase(Locale): String' is deprecated. Use lowercase() instead.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m 23s
11 actionable tasks: 11 executed

@monusingh-1
Copy link
Collaborator

Thanks Mohit, will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants