Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dashboards-maps: documents size limit #587

Open
cbeaujoin-stellar opened this issue Feb 22, 2024 · 8 comments
Open

[BUG] Dashboards-maps: documents size limit #587

cbeaujoin-stellar opened this issue Feb 22, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@cbeaujoin-stellar
Copy link

cbeaujoin-stellar commented Feb 22, 2024

What is the bug?

As described here: #141

Update default query document size limit to 1000, the max is from index.max_result_window size,

But in fact limitation is set to 10000 and is not aligned with index.max_result_window:

How can one reproduce the bug?

Create a map based on an index with number of documents and index.max_result_window greather than 10000.
You can't set a Number of Document greater than 10k.

What is the expected behavior?

UI should be aligned with the spec:

  • Limited to the index index.max_result_window

Idealy, maybe the maps plugin should use the scroll API when index.max_result_window > 10k

What is your host/environment?

docker, v2.11.1

Do you have any screenshots?

image

Do you have any additional context?

https://forum.opensearch.org/t/dashboards-maps-documents-size-limit/17983

@cbeaujoin-stellar cbeaujoin-stellar added bug Something isn't working untriaged labels Feb 22, 2024
@cbeaujoin-stellar cbeaujoin-stellar changed the title [BUG] [BUG] Dashboards-maps: documents size limit Feb 22, 2024
@junqiu-lei
Copy link
Member

junqiu-lei commented Feb 23, 2024

@cbeaujoin-stellar Thanks reporting, DOCUMENTS_DEFAULT_REQUEST_NUMBER was by designed to set to 1000 by default so avoid large number of data render issue.

@BionIT When we support multi data source, do you think if it's possible to read the value from index.max_result_window?

@cbeaujoin-stellar
Copy link
Author

Hi @junqiu-lei,
is this planned for 2.14.0 (May 14th, 2024) ?

@junqiu-lei
Copy link
Member

Assign to @vamshin to decide the priority.

@junqiu-lei junqiu-lei added enhancement New feature or request and removed bug Something isn't working labels Apr 5, 2024
@vamshin vamshin added the v2.15.0 label Apr 5, 2024
@vamshin
Copy link
Member

vamshin commented Apr 5, 2024

@cbeaujoin-stellar we are looking to have this delivered for 2.15.

@cbeaujoin-stellar
Copy link
Author

Do not forget that for next release, it's still very boring to manualy export edit import Maps objects Json file.

@junqiu-lei
Copy link
Member

@cbeaujoin-stellar After we looked into this issue, rendering issues can occur when large number of documents are visualized same time, which is why we have set the default document size to 1000. Additionally, the Maps app uses index patterns instead of single indices for data layers. An index pattern can encompass multiple indices, making it impractical to apply a single index's max_result_window setting in this context.

@cbeaujoin-stellar
Copy link
Author

I'm running it with 4 indices with 500k documents each, it's working fine.

@cbeaujoin-stellar
Copy link
Author

cbeaujoin-stellar commented Jun 17, 2024

It should at least be configurable according to management/opensearch-dashboards/settings > Custom vector map size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Planned work items
Development

No branches or pull requests

3 participants