Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Java 11 with Java 8 as the compilation toolchain #1406

Merged
merged 2 commits into from
May 19, 2022

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented May 18, 2022

Description

At a high-level, this PR adds a JDK 8 toolchain for compiling the Data Prepper main source code. It updates our GitHub Actions to build using Java 11.

Details:

  • Added the JDK 8 toolchain to the Data Prepper builds.
  • Use the JDK 11 toolchain for Data Prepper test code.
  • Updated GitHub Actions jobs to build using JDK 11 (Gradle runs in this JVM)
  • Use Tamarin/AdoptJDK as the base Docker image for end-to-end tests
  • Allow running Data Prepper in different JVM versions in end-to-end tests. Gradle still run in JDK 11, but Data Prepper will on a other JDKs.
  • Use a matrix to test Data Prepper logs end-to-end against JDK 8, 11, and 17.
  • Use a matrix to test Data Prepper logs end-to-end against JDK 11 and 17. It appears that the Traces fail on JDK 8, which is probably not a result of this PR.
  • Updated the developer documentation

Issues Resolved

Resolves #665

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…hain for compilation. Updated GitHub Actions to build using Java 11 and for end-to-end tests, run Data Prepper against multiple versions of Java.

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable requested a review from a team as a code owner May 18, 2022 20:16
… matrix.

Signed-off-by: David Venable <dlv@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1406 (dce92be) into main (1f95d08) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1406      +/-   ##
============================================
+ Coverage     94.08%   94.11%   +0.02%     
  Complexity     1156     1156              
============================================
  Files           162      162              
  Lines          3248     3247       -1     
  Branches        263      263              
============================================
  Hits           3056     3056              
+ Misses          138      137       -1     
  Partials         54       54              
Impacted Files Coverage Δ
.../com/amazon/dataprepper/parser/PipelineParser.java 89.69% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f95d08...dce92be. Read the comment docs.

@@ -13,16 +13,16 @@ jobs:
build:
strategy:
matrix:
java: [14]
java: [8, 11, 17]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this e2e also have JDK 8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Prepper should support JDK 8. I think the question is, why do the other tests not have JDK 8. :)

Unfortunately there does seem to be a bug with TLS on JDK 8 for gRPC. That appears to be a general issue beyond this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought since the source code builds on JDK 8 and the tests build on JDK 11, 8 is omitted from other tests. Not a blocker for this PR.

@dlvenable dlvenable merged commit da56180 into opensearch-project:main May 19, 2022
@dlvenable dlvenable deleted the java11 branch June 9, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build on JDK 11
5 participants