Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Duration support for Data Prepper Configuration using PluginDurationDeserializer #1623

Closed
asifsmohammed opened this issue Jul 27, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@asifsmohammed
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, only piplelines.yaml can be deserialized using PluginDurationDeserializer. It doesn't allow DataPrepperConfiguration to use Duration.

Describe the solution you'd like
One solution I could think of is make PluginDurationDeserializer a generic class instead of just for plugins and make it public. We can configure the object mapper of DataPrepperAppConfiguration here with custom deserializer.

@dlvenable
Copy link
Member

Additionally, this can formalize the concept of a "Data Prepper duration". This is an input string that can be in the format of either an ISO-8601 string or expressed as "Ns" or "Nms" for a specified second or millisecond value.

@asifsmohammed
Copy link
Member Author

Fixed as part of #1757

@dlvenable dlvenable added this to the v2.0 milestone Sep 15, 2022
@dlvenable dlvenable added enhancement New feature or request and removed untriaged labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants