-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ByteCount in plugin parser #3191
Comments
Hi @dlvenable , Could you please assign me this. |
@Durdush , Thank you for your interest in working this! Do you have any questions about how to accomplish it? I believe I have some information in the description to get started on it. |
Hi, is this issue still relevant? I can submit a PR to address this. Lines 40 to 43 in 553b4c1
Lines 30 to 37 in 553b4c1
I can use #3326 as reference since it's been a while since it's been active. |
This was partially resolved in I don't think we resolved this in |
Is your feature request related to a problem? Please describe.
Plugin authors must use strings and manually convert to use
ByteCount
in their configuration files.Describe the solution you'd like
Support
ByteCount
deserialization in the plugin parser. This would be similar to thedata-prepper-config.yaml
which supports it already. And it would give similar to behavior to the duration deserializer.Additional context
Needs to be added here:
data-prepper/data-prepper-core/src/main/java/org/opensearch/dataprepper/plugin/PluginConfigurationConverter.java
Line 37 in 59c48e2
Compare with:
data-prepper/data-prepper-core/src/main/java/org/opensearch/dataprepper/parser/config/DataPrepperAppConfiguration.java
Lines 34 to 36 in 35e37c6
The text was updated successfully, but these errors were encountered: