Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.12.0] Ensure CI/documentation reflect changes to default admin credentials #3978

Open
2 tasks
DarshitChanpura opened this issue Jan 18, 2024 · 4 comments
Open
2 tasks
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Milestone

Comments

@DarshitChanpura
Copy link
Member

Background

Previously, when installing the security plugin demo configuration, the cluster was spun up with the default admin credentials, admin:admin. A change was made in main and backported to 2.x for the 2.12.0 release, which now requires an initial admin password to be passed in via the environment variable OPENSEARCH_INITIAL_ADMIN_PASSWORD. This will break some CI/testing that relies on OpenSearch to come up without setting this environment variable. This tracking issue is to ensure compliance with the new changes.

Coming from: opensearch-project/security#3624

Acceptance Criteria

  • All documentation references to the old default credentials admin:admin are removed
  • Ensure that CI/testing is working with main and 2.x branches
@DarshitChanpura
Copy link
Member Author

Resolved by: #3869

@DarshitChanpura DarshitChanpura changed the title [v2.12.0] Ensure CI/documentation reflect changes to default admin credentials #1310 [v2.12.0] Ensure CI/documentation reflect changes to default admin credentials Jan 18, 2024
@dlvenable
Copy link
Member

@DarshitChanpura , @derek-ho ,

We have a few CI tests that are working currently because OpenSearch 2.12 is not yet released. These still assume the admin password.

  1. These work with older versions, so we probably need to set the password here to admin:

opensearch: [1.0.1, 1.1.0, 1.2.4, 1.3.14, 2.0.1, 2.1.0, 2.3.0, 2.5.0, 2.7.0, 2.9.0, 2.11.1]
fail-fast: false
runs-on: ubuntu-latest
steps:
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
- name: Checkout Data Prepper
uses: actions/checkout@v2
- name: Run OpenSearch docker
run: |
docker pull opensearchproject/opensearch:${{ matrix.opensearch }}
docker run -p 9200:9200 -p 9600:9600 -e "discovery.type=single-node" -d opensearchproject/opensearch:${{ matrix.opensearch }}

  1. Some of the Docker examples are using the latest version 2 and do not set or use the password.

https://github.com/search?q=repo%3Aopensearch-project%2Fdata-prepper+%22opensearch%3A2%22&type=code

@dlvenable
Copy link
Member

Also, see this comment:

#3869 (comment)

@DarshitChanpura
Copy link
Member Author

@dlvenable These need to be addressed post 2.12 release. OR a PR can be raised now that conditionally uses the correct password based on the version. The new password can be with env variable and it will only be picked up for >= 2.12 and will not be used on installs <2.12

@dlvenable dlvenable added maintenance Issues to help maintain the project, such as improving builds, testing, etc. and removed untriaged labels Jan 23, 2024
@dlvenable dlvenable added this to the v2.7 milestone Jan 23, 2024
@dlvenable dlvenable modified the milestones: v2.7, v2.8 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Development

No branches or pull requests

2 participants