Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompress processor #4016

Closed
Tracked by #3841
dlvenable opened this issue Jan 24, 2024 · 3 comments · Fixed by #4118
Closed
Tracked by #3841

Decompress processor #4016

dlvenable opened this issue Jan 24, 2024 · 3 comments · Fixed by #4118
Assignees
Labels
plugin - processor A plugin to manipulate data in the data prepper pipeline.
Milestone

Comments

@dlvenable
Copy link
Member

dlvenable commented Jan 24, 2024

Add a decompress processor:

processor:
  - decompress:
       keys: [my_gzip_key]
       type: gzip

Replace the value of the existing key with the decompressed value. Users likely don't want to save compressed values in OpenSearch.

See #3841 for more details.

@dlvenable dlvenable added plugin - processor A plugin to manipulate data in the data prepper pipeline. and removed untriaged labels Jan 24, 2024
@dlvenable dlvenable added this to the v2.7 milestone Jan 24, 2024
@graytaylor0
Copy link
Member

Should this processor also be responsible for decompressing from different encodings such as base64?

@dlvenable
Copy link
Member Author

@graytaylor0 , Ultimately to get binary data into Data Prepper, the source is decoding something. And there is something similar going out of Data Prepper. With DynamoDB and OpenSearch, binary data comes in as a base64-encoded string. But, some sources may have a different approach.

I tend to think that our Event model should have an internal model to represent binary data. This model could even avoid encoding/decoding when it is unnecessary.

This may be a bigger change than we need right now. I'd say that the decompress processor can just assume a base64-encoded string since that is what we get from DynamoDB and OpenSearch.

@dlvenable
Copy link
Member Author

@graytaylor0 , I put together an issue for handling binary data in a somewhat consistent way in Data Prepper: #4096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin - processor A plugin to manipulate data in the data prepper pipeline.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants