Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute Data Prepper Docker image with JDK 17 #694

Closed
3 tasks
dlvenable opened this issue Dec 1, 2021 · 4 comments · Fixed by #1727
Closed
3 tasks

Distribute Data Prepper Docker image with JDK 17 #694

dlvenable opened this issue Dec 1, 2021 · 4 comments · Fixed by #1727

Comments

@dlvenable
Copy link
Member

dlvenable commented Dec 1, 2021

Is your feature request related to a problem? Please describe.

The Data Prepper Docker image should include Corretto JDK 17 since it is an LTS version. The current Data Prepper Docker image includes Corretto 15. The tar.gz archive with JDK is also using JDK 15.

Describe the solution you'd like

Distribute Data Prepper Docker images with Amazon Corretto 11.

Describe alternatives you've considered (Optional)

Data Prepper could include AdoptOpenJDK 17 instead.

Data Prepper could use JDK 11 which is also LTS. However, we have found that simply updating to JDK 17 provides a performance improvement.

Tasks

  • Update the Docker image
  • Update the JDK which is installed in the tar.gz archive file
  • Update example Docker images
@dlvenable dlvenable added this to the v1.3 milestone Dec 1, 2021
@dlvenable
Copy link
Member Author

This is probably something that should be worked after #665. At that point, the Gradle build and the Docker image will be using the same Java version.

@dlvenable dlvenable added this to Untriaged in (deprecated) Tracking Board via automation Dec 2, 2021
@dlvenable dlvenable moved this from Untriaged to To do in (deprecated) Tracking Board Dec 2, 2021
@dlvenable dlvenable moved this from To do to Untriaged in (deprecated) Tracking Board Dec 2, 2021
@dlvenable dlvenable modified the milestones: v1.3, v2.0 Feb 18, 2022
@dlvenable dlvenable modified the milestones: v2.0, v1.4 Mar 15, 2022
@dlvenable dlvenable changed the title Distribute Data Prepper Docker image with JDK 11 Distribute Data Prepper Docker image with JDK 17 Mar 15, 2022
@dlvenable
Copy link
Member Author

As suggested in #1194, we may also wish to use the Alpine base image to reduce file size.

@dlvenable dlvenable removed this from the v1.4 milestone Apr 14, 2022
@dlvenable dlvenable added this to the v2.0 milestone Apr 19, 2022
@dlvenable dlvenable added the good first issue Good for newcomers label Jun 8, 2022
@dlvenable dlvenable moved this from Untriaged to To do in (deprecated) Tracking Board Jun 25, 2022
@oeyh oeyh moved this from To do to In progress in (deprecated) Tracking Board Sep 1, 2022
@dlvenable
Copy link
Member Author

OpenSearch distributes with Temurin for the JDK. Absent a specific need to support Corretto, I suggest that we also distribute with Temurin. This is a slight change from the original proposal.

@oeyh

@dlvenable
Copy link
Member Author

Temurin plans to support Java 17 through at least Oct 2027. Corretto has an end of life of Oct 2029. Both dates are sufficiently far in the future to where I don't see any benefit there.

https://adoptium.net/support/

https://aws.amazon.com/corretto/faqs/

@oeyh oeyh moved this from In progress to In review in (deprecated) Tracking Board Sep 7, 2022
@oeyh oeyh closed this as completed in #1727 Sep 8, 2022
(deprecated) Tracking Board automation moved this from In review to Done Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants