Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent HTTP source request timeout #975

Closed
dlvenable opened this issue Feb 3, 2022 · 0 comments · Fixed by #1814
Closed

Transparent HTTP source request timeout #975

dlvenable opened this issue Feb 3, 2022 · 0 comments · Fixed by #1814
Assignees
Milestone

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

The HTTP Source plugin provides a configurable request_timeout parameter. As a user, I'd expect that this is the actual timeout for HTTP requests.

However, the HTTP request timeout is doubled from that parameter.

Describe the solution you'd like

I propose the following changes:

  • No longer double the HTTP request timeout
  • Set the buffer timeout to a value derived from the request_timeout. My initial thought is that it can be 80% of the request_timeout. e.g. int bufferTimeoutMillis = (int)(0.8 * requestTimeoutMillis). Some additional logic may be necessary to ensure it is a valid time.

Additionally, the following can optionally be included:

  • A configuration for users to set their own buffer timeout. For example, buffer_timeout. This should have a default value so that user's don't have to configure it.

Describe alternatives you've considered (Optional)

There could be other approaches to deriving the buffer timeout from the request timeout. Perhaps subtracting some time rather than using a percentage. But, these would be more complicated because they would not work for smaller values. A future improvement could consider using a percentage when request_timeout is small and a subtraction approach when request_timeout is large enough. But, this seems unnecessary.

@dlvenable dlvenable added this to Untriaged in (deprecated) Tracking Board via automation Feb 3, 2022
@dlvenable dlvenable moved this from Untriaged to To do in (deprecated) Tracking Board Feb 3, 2022
@dlvenable dlvenable added this to the v1.4 milestone Mar 14, 2022
@dlvenable dlvenable self-assigned this Apr 26, 2022
@dlvenable dlvenable removed this from the v1.4 milestone May 10, 2022
@dlvenable dlvenable added this to the v2.0 milestone Jun 25, 2022
@dlvenable dlvenable added this to 2.0 - Breaking Changes (Aug/Sep 2022) in Data Prepper Project Roadmap Jun 25, 2022
@dlvenable dlvenable assigned oeyh and unassigned dlvenable Sep 26, 2022
(deprecated) Tracking Board automation moved this from To do to Done Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants