Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #17

Closed
dblock opened this issue Feb 14, 2023 · 8 comments
Closed

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #17

dblock opened this issue Feb 14, 2023 · 8 comments
Assignees
@ananzh

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.
@dblock dblock mentioned this issue Feb 14, 2023
Closed
87 tasks
@ananzh ananzh mentioned this issue Mar 8, 2023
Merged
3 tasks
@joshuarrrr joshuarrrr assigned joshuarrrr and ananzh and unassigned joshuarrrr Mar 15, 2023
@dblock
Copy link
Member Author

dblock commented Mar 23, 2023 •
edited

Permissions are incorrect. You have a group of 10+ people with maintain access. Please work with admin to sync.

Screenshot 2023-03-23 at 10 56 59 AM

@dblock dblock reopened this Mar 23, 2023
ananzh added a commit to ananzh/i18n-plugin-1 that referenced this issue Apr 5, 2023
@ananzh
Update CODEOWNERS
5329344 
Issue Resolve
opensearch-project#17

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Apr 5, 2023
Merged
3 tasks
@ananzh ananzh closed this as completed in d3600f7 Apr 5, 2023
@dblock
Copy link
Member Author

dblock commented Apr 6, 2023 •
edited

Permissions are still incorrect, please work with an admin to fix.

Screenshot 2023-04-06 at 10 09 43 AM

@dblock dblock reopened this Apr 6, 2023
@ananzh
Copy link
Member

ananzh commented Apr 6, 2023

For the permission update, we don't have access. I will reach out to the build team to check if they could help. @bbarani @zelinh

@ananzh
Copy link
Member

ananzh commented Apr 6, 2023 •
edited

@zelinh,

Regarding the following two points:

  • Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  • All other teams are removed from repo permissions.

Is there some guide to know 1) who should have permissions? CODEOWNERS? 2) what permissions should we provide?
Could you help us to update? Thank you.

@zelinh
Copy link
Member

zelinh commented Apr 6, 2023

After offline discussion with @ananzh, I believe she has the access to proceed here now.

@ananzh
Copy link
Member

ananzh commented Apr 6, 2023

I have updated to this

Screenshot 2023-04-06 at 13 12 30

@ananzh
Copy link
Member

ananzh commented Apr 20, 2023

Since permissions are updated, will close this issue.

@ananzh ananzh closed this as completed Apr 20, 2023
@dblock
Copy link
Member Author

dblock commented Apr 24, 2023

Verified, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dblock @seanneumann @joshuarrrr @ananzh @zelinh