Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ensure the GIthub workflow pull docker image used by infra build #1042

Closed
vamshin opened this issue Aug 15, 2023 · 1 comment
Closed
Assignees

Comments

@vamshin
Copy link
Member

vamshin commented Aug 15, 2023

Is your feature request related to a problem?
Ensure the GIthub workflow uses docker images that are used during the infra build for running integration tests.
This is to make sure, integration tests are run on same environment as that of infra build and help catch issues early. WE recently noticed such discrepancy with GCC version incompatibility when FAISS library got upgraded which required more upgraded version of GCC

What solution would you like?
k-NN GIthub workflow should pull docker images of build team instead of latest Ubuntu version

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@navneet1v
Copy link
Collaborator

Closing the issue as the changes are merged in all the respective branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants