Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #37

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 7 comments · Fixed by #39
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #37

dblock opened this issue Feb 14, 2023 · 7 comments · Fixed by #39
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@dblock
Copy link
Member Author

dblock commented Mar 23, 2023

Permissions are incorrect. You have 10+ people with maintain access. Please work with admin to sync.

Screenshot 2023-03-23 at 10 58 11 AM

@dblock dblock reopened this Mar 23, 2023
@junqiu-lei
Copy link
Member

Thanks @dblock, just updated the maintain access permission to individual alias based on CODEOWNERS, thanks @peterzhuamazon help

@dblock
Copy link
Member Author

dblock commented Mar 30, 2023

There should be 3 maintainers according to maintainers file. This is what I see in settings.

Screenshot 2023-03-30 at 10 30 36 AM

@dblock dblock reopened this Mar 30, 2023
@junqiu-lei
Copy link
Member

Hi @dblock , the maintainers are updated, could you help double check? Thank you!

@dblock
Copy link
Member Author

dblock commented Apr 4, 2023

Doesn't look correct. You have all these people with write access that should not have it, only folks in MAINTAINERS should have maintain access. Please work with an admin on fixing it?

Screenshot 2023-04-04 at 12 11 10 PM

@junqiu-lei
Copy link
Member

Updated, please help check whenever you get a chance, thanks! @dblock

Screenshot 2023-04-04 at 12 22 32 PM

@dblock
Copy link
Member Author

dblock commented Apr 27, 2023

Verified, thx. I added Triage group with triage permissions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants