Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move notifications-core into its own repo #405

Open
dblock opened this issue Apr 13, 2022 · 0 comments
Open

Move notifications-core into its own repo #405

dblock opened this issue Apr 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Apr 13, 2022

Is your feature request related to a problem? Please describe.

The notifications repo is the only one in OpenSearch plugins that produces 2 plugins, notifications and notifications-core. This breaks some assumptions made by the distribution. For example, we had to do a hack (and as a consequence notifications build scripts cannot be checked into the notifications repo) in opensearch-project/opensearch-build#1959, and I suspect we will have to do more. Supporting multiple artifacts was attempted in opensearch-project/opensearch-build#1956 but had other drawbacks.

Describe the solution you'd like

It seems like the easiest solution to avoid these hacks is to put notifications-core into its own project and repo.

Alternatively we should probably go finish the work in opensearch-project/opensearch-build#1956.

@dblock dblock added the enhancement New feature or request label Apr 13, 2022
@lezzago lezzago mentioned this issue Mar 2, 2023
1 task
This was referenced Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant