Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Run integration tests as part of the OpenSearch-Dashboards distribution #433

Closed
Tracked by #58
dblock opened this issue Apr 27, 2022 · 7 comments
Closed
Tracked by #58
Labels

Comments

@dblock
Copy link
Member

dblock commented Apr 27, 2022

Is your feature request related to a problem?
Following a problem in another plugin (opensearch-project/opensearch-build#2043), and coming from opensearch-project/opensearch-build#58, there's no automated testing that this plugin runs as part of the OpenSearch distribution.

What solution would you like?
Run integration tests as part of the distribution.

@peterzhuamazon
Copy link
Member

Their PR, check failed, not merged:
opensearch-project/opensearch-dashboards-functional-test#185

@peterzhuamazon
Copy link
Member

Test merged.

@qreshi
Copy link
Contributor

qreshi commented Apr 29, 2022

@peterzhuamazon Just to confirm, even before this issue was created, we were already running the backend integration tests that we already have for this repo against the distribution correct?

The issue linked above is for the frontend tests which were not in place.

@peterzhuamazon
Copy link
Member

@peterzhuamazon Just to confirm, even before this issue was created, we were already running the backend integration tests that we already have for this repo against the distribution correct?

The issue linked above is for the frontend tests which were not in place.

Merged in opensearch-project/opensearch-dashboards-functional-test#185.
Please consider fixing the issues there.

Thanks.

@qreshi
Copy link
Contributor

qreshi commented Apr 29, 2022

My question is on the backend integration tests, not the frontend ones. This issue implied we had no integration tests which is not true since there were always backend integration tests. Just making sure those were being run for the OpenSearch distribution already.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Apr 29, 2022

My question is on the backend integration tests, not the frontend ones. This issue implied we had no integration tests which is not true since there were always backend integration tests. Just making sure those were being run for the OpenSearch distribution already.

BE integTest is there this issue is for dashboards.
I will change the title seems initial title is misleading.
Sorry and thanks.

@peterzhuamazon peterzhuamazon changed the title [FEATURE] Run integration tests as part of the OpenSearch distribution [FEATURE] Run integration tests as part of the OpenSearch-Dashboards distribution Apr 29, 2022
@qreshi
Copy link
Contributor

qreshi commented Apr 29, 2022

Got it, thanks Peter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants