Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to test results in the OSD integ test notification #1728

Closed
Tracked by #604
tianleh opened this issue Mar 9, 2022 · 7 comments
Closed
Tracked by #604

Add links to test results in the OSD integ test notification #1728

tianleh opened this issue Mar 9, 2022 · 7 comments
Labels
enhancement New Enhancement

Comments

@tianleh
Copy link
Member

tianleh commented Mar 9, 2022

Is your feature request related to a problem? Please describe

Currently only the Jenkins job link is posted in the OSD integ test notification. This is not convenient to look at where the failures are. Since the test result is uploaded under CloudFront, we can include the ci endpoint for test results.

E.g

https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/1.3.0/1484/linux/x64/test-results/b94f426463b24046a2ed33c5be290508/integ-test/functionalTestDashboards/without-security/test-results/stdout.txt

At minimum, we shall include the url to stdout.txt for without-security and with-security. We can also consider include links to the video and screenshots.

Describe the solution you'd like

At minimum, we shall include the url to stdout.txt for without-security and with-security. We can also consider include links to the video and screenshots.

Describe alternatives you've considered

No response

Additional context

No response

@tianleh tianleh added enhancement New Enhancement untriaged Issues that have not yet been triaged and removed untriaged Issues that have not yet been triaged labels Mar 9, 2022
@kavilla kavilla linked a pull request Mar 9, 2022 that will close this issue
1 task
@tianleh
Copy link
Member Author

tianleh commented Mar 10, 2022

Currently the url has a random hash which makes it difficult to share. We can pass a test run ID to https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch-dashboards/integ-test.jenkinsfile#L68

Then the location of test file will use the input instead of random value https://github.com/opensearch-project/opensearch-build/blob/main/src/test_workflow/test_recorder/test_recorder.py#L21

Then we will be able to construct the test result url.

@tianleh
Copy link
Member Author

tianleh commented Mar 10, 2022

cc @kavilla

@tianleh
Copy link
Member Author

tianleh commented Mar 10, 2022

I think we can just pass --test-run-id 1 when running the integ test Jenkins job. Then we know how to get the test result url and then can include it in the message notification for stakeholders to troubleshoot.

cc @dblock

@bbarani
Copy link
Member

bbarani commented Jun 13, 2022

@tianleh Can you update the current status?

@tianleh
Copy link
Member Author

tianleh commented Jun 15, 2022

@tianleh Can you update the current status?

The issue has a pre-request PR https://github.com/opensearch-project/opensearch-build/pull/2028/files which was waiting for post 2.0 release. I will bring the related PR to sync up with latest main branch. After that, the issue just needs to include the test result link in the message notification.

@bbarani
Copy link
Member

bbarani commented Jan 30, 2023

@tianleh Can you update the current status?

@gaiksaya
Copy link
Member

gaiksaya commented Jan 5, 2024

Thanks to @zelinh we recently introduced reporting workflow #1274 that generated an overview of all the tests and includes sub-reports that contains links to all test files including videos, stdout, stderr, etc.
Example: opensearch-project/dashboards-observability#1031 (comment)

Closing this issue. Thanks!

@gaiksaya gaiksaya closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants