Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Add support for inclusive naming for all clients #16

Closed
9 tasks done
saratvemulapalli opened this issue Apr 20, 2022 · 4 comments
Closed
9 tasks done

[META] Add support for inclusive naming for all clients #16

saratvemulapalli opened this issue Apr 20, 2022 · 4 comments
Labels
enhancement New feature or request meta

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Apr 20, 2022

Is your feature request related to a problem?
Starting with OpenSearch 2.0, we are moving to support inclusive naming across the project.
Ref:
[1] opensearch-project/OpenSearch#472
cc: @tlfeng

Coming from: opensearch-project/opensearch-py#156 (comment)

What solution would you like?
Add support to new inclusive REST API usages.
Change any internal REST API calls (which don't face to user) to use new inclusive usages, instead of the old REST APIs that contain "master" terminology. Otherwise, using REST API usages with "master" word will lead to deprecation warning emitted from OpenSearch server.
Additional Context:
The REST API and setting changes about "master" terminology:
opensearch-project/documentation-website#450

The setting change about "blacklist / whitelist" terminology:
opensearch-project/documentation-website#449

Note: The REST API parameter "master_timeout" is not deprecated in 2.0 (but in 3.0) to keep the compatibility of OpenSearch "High Level REST Client" with server version 1.x (See the issue opensearch-project/OpenSearch#2928 for detail)

Tracking changes in clients

@tlfeng
Copy link

tlfeng commented Apr 22, 2022

You could feel free to add the following to the top ^ 😁 :

Suggested solution:

  1. Add support to new inclusive REST API usages.
  2. Change any internal REST API calls (which don't face to user) to use new inclusive usages, instead of the old REST APIs that contain "master" terminology. Otherwise, using REST API usages with "master" word will lead to deprecation warning emitted from OpenSearch server.

Additional Context:
The REST API and setting changes about "master" terminology:
opensearch-project/documentation-website#450

The setting change about "blacklist / whitelist" terminology:
opensearch-project/documentation-website#449

Note: The REST API parameter "master_timeout" is not deprecated in 2.0 (but in 3.0) to keep the compatibility of OpenSearch "High Level REST Client" with server version 1.x (See the issue opensearch-project/OpenSearch#2928 for detail)

@saratvemulapalli
Copy link
Member Author

@VachaShah
Copy link
Collaborator

Thank you @saratvemulapalli for opening this! Converting this into a meta issue to track the changes for various clients.

@VachaShah
Copy link
Collaborator

Closing this issue since all existing clients support inclusive naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request meta
Projects
None yet
Development

No branches or pull requests

3 participants