Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes and migration #231

Closed
boktorbb opened this issue Mar 23, 2021 · 4 comments
Closed

Breaking changes and migration #231

boktorbb opened this issue Mar 23, 2021 · 4 comments
Assignees
@kavilla
Labels
build Build related additions or modifications migration Any plans, changes, or enhancements needed for migration
Projects
Dashboards Core
Milestone
1.x release

Comments

@boktorbb
Copy link
Contributor

boktorbb commented Mar 23, 2021 •
edited by mihirsoni

This issue is to track all the breaking changes after rename exercise.
@boktorbb boktorbb added build Build related additions or modifications migration Any plans, changes, or enhancements needed for migration labels Mar 23, 2021
@boktorbb boktorbb added this to the 1.x release milestone Mar 23, 2021
@boktorbb boktorbb added this to To do in Dashboards Core via automation Mar 23, 2021
@kavilla kavilla moved this from To do to In progress in Dashboards Core May 5, 2021
@kavilla kavilla self-assigned this May 5, 2021
@kavilla
Copy link
Member

kavilla commented May 5, 2021

Most, if not all, saved objects had the property kibanaSavedObjectMeta within the rename we changed this to opensearchDashboardsSavedObjectMeta. Which has prevented objects from being imported.

@kavilla
Copy link
Member

kavilla commented May 5, 2021 •
edited

The default index changed from .kibana to .opensearch_dashboards this should cause issues while migrating automatically.

@mihirsoni
Copy link
Contributor

Url redirections from /kibana to opensearch_dashboards

@kavilla
Copy link
Member

kavilla commented May 14, 2021

Will close this one and will address the issue in this issue: #334

@kavilla kavilla mentioned this issue May 14, 2021
Closed
@kavilla kavilla closed this as completed May 14, 2021
Dashboards Core automation moved this from In progress to Done May 14, 2021
SuZhou-Joe added a commit to wanglam/OpenSearch-Dashboards that referenced this issue Oct 16, 2023
@SuZhou-Joe @gaobinlong
Patch/acl (opensearch-project#231)
120d3b7 
* consume permissions in repository

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: consume permissions in serializer

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Add unit tests for consuming permissions in repository

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Co-authored-by: gaobinlong <gbinlong@amazon.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this issue Feb 22, 2024
@SuZhou-Joe @gaobinlong @wanglam
Patch/acl (opensearch-project#231)
d47cdfb 
* consume permissions in repository

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: consume permissions in serializer

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Add unit tests for consuming permissions in repository

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Co-authored-by: gaobinlong <gbinlong@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Mar 18, 2024
@SuZhou-Joe @gaobinlong
Patch/acl (opensearch-project#231)
63e8e9d 
* consume permissions in repository

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: consume permissions in serializer

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Add unit tests for consuming permissions in repository

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Co-authored-by: gaobinlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kavilla kavilla

Labels
build Build related additions or modifications migration Any plans, changes, or enhancements needed for migration
Projects
Dashboards Core
  
Done
Milestone
1.x release
Development

No branches or pull requests
3 participants
@mihirsoni @kavilla @boktorbb