Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for allow_leading_wildcard to search #103

Closed
wants to merge 1 commit into from

Conversation

nevins-b
Copy link

Description

Allow for setting, disabling, allow_leading_wildcard on a search

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nevins-b nevins-b requested review from a team and svencowart as code owners April 28, 2022 20:58
@dblock
Copy link
Member

dblock commented May 3, 2022

Thanks! Happy to take this with some tests, please?

@nevins-b
Copy link
Author

nevins-b commented May 3, 2022

@dblock Sure, I didn't see a place to add tests. I could add something to the benchmark tests but that didn't feel right. Suggestion of where I would add some?

@dblock
Copy link
Member

dblock commented May 6, 2022

Not a go expert nor have I looked in detail into opensearch-go to say where those tests should go, but looks like there's a bunch of tests that are running (https://github.com/opensearch-project/opensearch-go/runs/6070092469?check_suite_focus=true). I'd like us not to merge untested code, so if you need to introduce a new set of tests and just test this one addition, let's do it?

@VachaShah
Copy link
Collaborator

@nevins-b Thank you for this PR! May be the tests can go here?

@wbeckler
Copy link

Hi @nevins-b, do you think you'll want this merged? If nobody adds tests or moves this forward, I propose we close this PR.

@Jakob3xD
Copy link
Collaborator

Jakob3xD commented Apr 6, 2023

While looking into the PR I noticed that allow_leading_wildcard does not seems to be a parameter for a search request.
allow_leading_wildcard is a filed of query_string in the search body. The body is given via the user so adding this to search prams would not work. https://opensearch.org/docs/latest/query-dsl/full-text/query-string/

I suggest closing the PR. @wbeckler

@wbeckler
Copy link

wbeckler commented Apr 7, 2023

I'm okay with closing this. Any other maintainers have a thought?

@dblock dblock closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants