Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenSearchNodesClient#info is unable to parse custom roles #893

Open
dennisoelkers opened this issue Mar 14, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@dennisoelkers
Copy link

What is the bug?

When a node exists in the cluster having a (custom) role which is not listed in NodeRole, executing OpenSearchClient#nodes#info fails with a JsonParsingException: Invalid enum 'customrole'.

How can one reproduce the bug?

Start a node in the cluster with a custom role.

What is the expected behavior?

OpenSearchClient#nodes#info should succeed, either stripping the custom role from the list of roles of that node, or returning a collection of strings instead of enums.

What is your host/environment?

Operating system, version.

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

@dennisoelkers
Copy link
Author

Btw, this also happens when the search role is added, as suggested here.

@dennisoelkers
Copy link
Author

dennisoelkers commented Mar 25, 2024

@dblock, @reta: Is this of any relevance for the team? This is blocking adoption of the client for us and there is no response from maintainers of the client yet. We are wondering if deprecating the previous client is a little bit premature?

@reta
Copy link
Collaborator

reta commented Mar 25, 2024

@dennisoelkers we would greatly appreciate a pull request for this issue, if you are up to it, thank you!

@dblock dblock removed the untriaged label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants