Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize design documentation for plugin features #42

Open
ohltyler opened this issue Jun 9, 2021 · 8 comments
Open

Standardize design documentation for plugin features #42

ohltyler opened this issue Jun 9, 2021 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ohltyler
Copy link
Member

ohltyler commented Jun 9, 2021

Opening this issue to discuss different options and agree upon a standard for plugins to follow.

Currently, not many detailed design docs for implemented features in plugins are checked into their respective repos. Some benefits of including these in the repos:

  1. Increases community transparency regarding technical details of existing plugin features + upcoming features
  2. Increases community involvement in the feature development lifecycle of large features
  3. Can be referenced in relevant PRs to help provide context to the code changes

I propose to hold design reviews via opening & reviewing PRs that are checking in a design doc for a new feature. Discussion can take place on the PR itself, and when the feature is finalized, it can be checked into a docs/ directory in the plugin repo.

To handle the problem of docs becoming stale over time, the docs themselves can include links to the RFC for the feature, and the creation date.

Please add any thoughts / comments to this.

@dblock dblock added the enhancement New feature or request label Jun 9, 2021
@saratvemulapalli saratvemulapalli added the v1.0.0 OpenSearch 1.0 Release label Jun 9, 2021
@dblock dblock changed the title Standardizing documentation for plugin features Standardize design documentation for plugin features Jun 9, 2021
@saratvemulapalli
Copy link
Member

Thanks @ohltyler for this. Love the idea.
Was just exploring better ways to represent design docs and found this: https://github.com/vitiral/artifact

@saratvemulapalli saratvemulapalli added the help wanted Extra attention is needed label Jun 11, 2021
@joshuali925
Copy link
Member

Any guidance on this?

@ohltyler
Copy link
Member Author

@saratvemulapalli what do you think about moving this to v1.1.0? I think this is kind of a larger and slower process in the change in where design doc discussions happen, rather than a concrete change that can happen by this release. Maybe have a concrete requirement to convert & merge main design docs into GitHub by 1.1?

@saratvemulapalli
Copy link
Member

@saratvemulapalli what do you think about moving this to v1.1.0? I think this is kind of a larger and slower process in the change in where design doc discussions happen, rather than a concrete change that can happen by this release. Maybe have a concrete requirement to convert & merge main design docs into GitHub by 1.1?

+1 I agree, anyway we will not have any new designs for 1.0.0.

@saratvemulapalli saratvemulapalli added v1.1.0 and removed v1.0.0 OpenSearch 1.0 Release labels Jun 24, 2021
@ohltyler
Copy link
Member Author

Cool. Please update #41 as well to remove that checkbox.

@saratvemulapalli
Copy link
Member

@elfisher @ahopp @aetter any thoughts on this?

@elfisher
Copy link

elfisher commented Aug 5, 2021

I like this idea.

@dblock
Copy link
Member

dblock commented Sep 22, 2021

How do we move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants