Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS OSS Maven -SNAPSHOT for plugin dependencies #45

Closed
14 tasks done
Tracked by #567
saratvemulapalli opened this issue Jun 9, 2021 · 23 comments
Closed
14 tasks done
Tracked by #567

Use AWS OSS Maven -SNAPSHOT for plugin dependencies #45

saratvemulapalli opened this issue Jun 9, 2021 · 23 comments
Assignees
Labels
enhancement New feature or request v1.2.0

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Jun 9, 2021

Plugins should not build off OpenSearch/plugins for every build.

See https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#building-within-the-opensearch-build-system for picking up dependencies from Maven.

@saratvemulapalli saratvemulapalli added enhancement New feature or request v1.0.0 OpenSearch 1.0 Release labels Jun 9, 2021
@ylwu-amzn
Copy link

ylwu-amzn commented Jun 21, 2021

Is this the goal of GA release? Any guidance

@dblock
Copy link
Member

dblock commented Jun 22, 2021

@ylwu-amzn Yes, we're waiting for Maven to be setup.

@joshuali925
Copy link
Member

@dblock any eta on when plugins can start this?

@saratvemulapalli
Copy link
Member Author

@dblock any eta on when plugins can start this?

@mch2 is working on it.

@mch2
Copy link
Member

mch2 commented Sep 1, 2021

Plugins can start updating their scripts to depend on 1.0 artifacts from central.

If a snapshot of an unreleased version is desired you can add https://aws.oss.sonatype.org/content/repositories/snapshots/ to your list of repositories. This is where nightly builds are being pushed of 1.0 and 1.x.

@dblock
Copy link
Member

dblock commented Sep 2, 2021

Someone needs to pickup a task of upgrading an existing plugin to use maven -SNAPSHOT dependencies for 1.1, make sure it works, and then open an issue in every repo to do the same.

@abbashus
Copy link
Contributor

abbashus commented Sep 2, 2021

Someone needs to pickup a task of upgrading an existing plugin to use maven -SNAPSHOT dependencies for 1.1, make sure it works, and then open an issue in every repo to do the same.

I'll pick this up

@dblock
Copy link
Member

dblock commented Sep 2, 2021

@dbbaughe
Copy link

dbbaughe commented Sep 9, 2021

@saratvemulapalli
Copy link
Member Author

For all plugins who are onboarding to Maven, please continue to list mavenlocal() as one of the repositories.
Pasting the comment from: https://github.com/opensearch-project/index-management/pull/141/files#r706333121

"As part of the CI/CD we are trying to run integration/bwc tests which qualifies the bundle and allows the maven artifacts to be published.
It would rely on mavenlocal() to run these tests."

@dblock
Copy link
Member

dblock commented Sep 22, 2021

Changing the label for 1.2. We need to update https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md, open an issue in every plugin and make sure this is closed. @abbashus do you still own this?

@dblock dblock added v1.2.0 and removed v1.1.0 labels Sep 22, 2021
@abbashus
Copy link
Contributor

@dblock yes I still own this. Will start in a couple of days.

@dblock
Copy link
Member

dblock commented Sep 28, 2021

@dblock
Copy link
Member

dblock commented Oct 12, 2021

I updated the top of this ticket with a complete list of projects that need to do this.

@CEHENKLE
Copy link
Member

All tickets closed :)

@dblock
Copy link
Member

dblock commented Nov 12, 2021

Verified via meta, found 3 occurrences. Not sure whether these are used, and I know notifications doesn't ship with 1.2. Reopening to fix and re-confirm.

meta exec "git checkout 1.2"
find . -type f -regex '.*/\.github\/workflows\/.*.yml' | xargs grep "'opensearch-project/OpenSearch'"

./dashboards-notebooks/.github/workflows/opensearch-notebooks-test-and-build-workflow.yml:          repository: 'opensearch-project/OpenSearch'
./security-dashboards-plugin/.github/workflows/integration-test.yml:          repository: 'opensearch-project/OpenSearch'
./notifications/.github/workflows/notifications-test-and-build-workflow.yml:          repository: 'opensearch-project/OpenSearch'

@dblock dblock reopened this Nov 12, 2021
@anirudha
Copy link

Notebooks and notifications are not part of 1.2

@dblock
Copy link
Member

dblock commented Nov 12, 2021

Looks like dashboards-notebooks is going to get archived, opensearch-project/dashboards-notebooks#98 (comment)

@dblock
Copy link
Member

dblock commented Nov 17, 2021

Spot checked again, opensearch-project/security-dashboards-plugin#860 still needs to be backported to 1.2 to close this.

@dblock dblock assigned dblock and unassigned abbashus Nov 17, 2021
@peterzhuamazon
Copy link
Member

@saratvemulapalli @dblock is this task consider complete? This is the only issue labeled as enhancement within 1.2.0.

@dblock
Copy link
Member

dblock commented Dec 7, 2021

I don’t see any mention of a backport for opensearch-project/security-dashboards-plugin#860 so that needs to be tracked down.

@dblock
Copy link
Member

dblock commented Apr 18, 2022

@dblock dblock closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.2.0
Projects
None yet
Development

No branches or pull requests

10 participants