Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Use of >= style dependencies for aws crates breaking downstream builds #223

Closed
bcpeinhardt opened this issue Nov 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@bcpeinhardt
Copy link

What is the bug?

Presently, in opensearch version 2.2, aws dependencies are being specified using >= like so

aws-credential-types = { version = ">= 0.57, <1.0", optional = true }
aws-sigv4 = { version = ">= 0.57, <1.0", optional = true }
aws-smithy-runtime-api = { version = ">= 0.57, <1.0", optional = true, features = ["client"]}
aws-types = { version = ">= 0.57, <1.0", optional = true }

the <1.0 was added later (presumably to fix downstream build issues being caused by bringing in v1.x.x).
Here is the commit: 5a2ae45

I'm hoping this fix can be back ported to opensearch version 2.1. The lack of the proper pinning is breaking our downstream
builds, but upgrading to 2.2 would require upgrading aws-* dependency versions in other libraries.

@bcpeinhardt bcpeinhardt added bug Something isn't working untriaged labels Nov 28, 2023
@Xtansia Xtansia removed the untriaged label Nov 28, 2023
@Xtansia
Copy link
Collaborator

Xtansia commented Nov 28, 2023

Hi @bcpeinhardt, Thanks for reporting this, I'll work on backporting a fix to 2.1, in the meantime I believe you should be able to workaround this by pinning to the correct versions in your crate, as it'll prefer to use an already requested compatible version rather than introduce a new version:

[dependencies]
opensearch = { version = "2.1.0", features = ["aws-auth"] }
aws-sigv4 = "0.55"
aws-types = "0.55"
aws-config = "0.55"
aws-credential-types = "0.55"

@Xtansia
Copy link
Collaborator

Xtansia commented Nov 28, 2023

@bcpeinhardt I've now released a v2.1.1 that correctly bounds the aws-* dependencies to the code-compatible versions

@Xtansia Xtansia closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants