-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] Combine gems, extract opensearch-aws-sigv4 #133
Comments
This will solve a lot of our DevOps problems and bring Ruby inline with other languages. |
Should we keep |
Do we know if anyone is actually using opensearch-dsl separately? And are we just saving disk space? |
One of the applications I worked in the past didn't use |
I don't have any strong opinions if you think it's useful! |
@dblock Would you mind creating |
@dblock: I've just discussed with @vamshin regarding dsl-py where we've merged it into the Python client instead of maintaining it as a standalone package like we planned to above. @vamshin brought up a valid point that addresses my micro-service concern: The footprint of the DSL library is minuscule. So, to reduce the overhead of maintaining another repo and keep it consistent with other clients, let's merge the DSL gem into the Ruby Client gem as well. |
Hi there, just a quick question: am I correct to assume that the merge hasn't been completed yet? |
@RuslanHassonov sorry I missed this. It's a WIP and almost done #175 |
What/Why
What are you proposing?
There are 5 gems in this repo:
All except
opensearch-aws-sigv4
are always used by anyone wanting to call OpenSearch in Ruby.What users have asked for this feature?
Coming from #127.
What problems are you trying to solve?
What is the developer experience going to be?
Major increment opensearch-ruby and collapse the other 3 gems into it.
Extract code for opensearch-aws-sigv4 into a new repo called opensearch-ruby-aws-sigv4.
The text was updated successfully, but these errors were encountered: