Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL for AD Extension] Mofication required in JS libraries usage in AD extension #739

Open
vibrantvarun opened this issue May 8, 2023 · 0 comments

Comments

@vibrantvarun
Copy link
Member

What/Why

What are you proposing?

AD as an extension should get rid of the dependency from Job scheduler jar file in the codebase and should only be using Job scheduler zip file for the dependency.

Also, if possible we need to create similar classes which we are using from Job scheduler in AD extension so that we can just rely on Rest Api's to handle the communication.

What problems are you trying to solve?

AD extension uses Job Scheduler code in it. This code is creating dependencies on Job Scheduler Jar file in AD extension.
Therefore AD extension has to depend on Job scheduler build to update artifacts in 2 maven coordinates. Below are two mentioned paths from sonatype on which JS depends.
org.opensearch.opensearch-job-scheduler. -> Jar file
org.opensearch.plugin.opensearch-job-scheduler -> Zip file

AD extension should only fetch dependencies from the Zip file.
Also, publishing artifacts at 2 places increases overhead on the build system and consumes more time to build.

Are there any breaking changes to the API

Yes, the feature either needs redesigning or modification of the communication mechanism between JS or AD extension.

Are there breaking changes to the User Experience?

No

@vibrantvarun vibrantvarun changed the title [PROPOSAL for AD Extension] JS libraries usage in AD extension [PROPOSAL for AD Extension] Mofication required in JS libraries usage in AD extension May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants