Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Remove routeNamePrefix to use extensionName and update the NamedRoute regex pattern. #871

Open
DarshitChanpura opened this issue Jul 11, 2023 · 1 comment

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Jul 11, 2023

Coming from #868.
Adding routeNamePrefix has a tendency to complicate the design, as a new setting is introduced. As an improvement to address this complication, a change is proposed to use extensionName as the prefix, and update the regex validation pattern in NamedRoute to also include -.
Ask: Check if this is needed?

@owaiskazi19 Please update the description as necessary as you had thoughts on it.

@dbwiddis
Copy link
Member

2.9.0 code freeze is imminent. We need to wrap up this discussion promptly and if we are relaxing NamedRoutes that needs to happen ASAP.

This whole prefix conversation is:

  • around an optional Base superclass
  • just a convenience to avoid users defining a constant somewhere and using it

If we're concerned about complicating the design can we just simply remove the prefix method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants