Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Integrate with OpenSearch Settings #84

Open
3 of 7 tasks
dbwiddis opened this issue Nov 15, 2023 · 2 comments
Open
3 of 7 tasks

[META] Integrate with OpenSearch Settings #84

dbwiddis opened this issue Nov 15, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Nov 15, 2023

Is your feature request related to a problem?

Extensions may have their own settings that must be registered with OpenSearch.

Extensions may make use of OpenSearch settings and need to subscribe to changes in those settings.

What solution would you like?

  • A local copy of OpenSearch settings populated at initialization
  • A Setting class porting the relevant settings creation portions of Setting
  • Relevant transport-related portions of the individual Setting subclasses
  • Relevant transport-related portions of the overall WriteableSetting
  • A getSettings() extension point on the Extension interface
  • A handler for registering settings obtained from the above interface
  • A handler for subscribing to and receiving setting updates

What alternatives have you considered?

None; the above most closely resembles the Java SDK implementation which required multiple iterations to get right.

Do you have any additional context?

The Java WriteableSetting constructor takes a Setting<T> object as a parameter with this Setting used in the extension. Given that we are not importing the Python class it is entirely reasonable to combine the functionality of the two classes.

@dbwiddis dbwiddis added enhancement New feature or request untriaged Issues that require attention from the maintainers. help wanted Extra attention is needed and removed untriaged Issues that require attention from the maintainers. labels Nov 15, 2023
@dblock
Copy link
Member

dblock commented Dec 26, 2023

@dbwiddis update this one with current status?

@dbwiddis
Copy link
Member Author

It's up to date. The third bullet is partially complete but still doesn't have transport for the superclass. I'll split it into two parts to make it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants