-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default CI Java Version to Java 11, run tests on 8, 14 and 17 #230
Comments
by adding to "CI matrix", does it mean github CI matrix? It confuses me with the 1st bullet point. Are we using a fixed version or a matrix in github action CI workflow for plugins? @dblock |
I tried adding java 8 to the matrix in gitub CI by "setup-java/@v2", I saw the following error. It seems from the doc the opensearch core is expecting the compile time java to be at least 11, while for runtime it could be 8, 11, 14. Need some advice from infra on how to add to github action CI. I think it should be similar across plugins
|
This is expected, we only want to run tests on 8 but compiling on 11 is fine. I am not sure exactly how to do this in CI (yet). |
@davidcui1225 You still need a 1.3.0 build on JDK 8, don't see it in the workflows. |
Are we pushing back the release date? The code freeze is EOD today, we will only have ~2 hours to get these all merged in. |
Coming from opensearch-project/opensearch-plugins#64, default CI Java version to 11 (LTS), and run tests on 8, 14 and 17.
The text was updated successfully, but these errors were encountered: