Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Test Netty4HttpHeaderVerifier with different types of persistent connections #3507

Open
3 tasks
cwperks opened this issue Oct 9, 2023 · 1 comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Oct 9, 2023

While developing on #3418, it was noticed that the Security plugin does not have any tests around behavior with different types of http persistent connections.

#3418 Adds a new step in the netty pipeline called Netty4HttpHeaderVerifier that verifies a request and uses channel attributes to carry information to future steps in the pipeline. With persistent connections, only a single request/response can occupy a channel until the next request goes through the channel. In Pipelining and Multiplexing, http introduced some optimizations to increase the throughput of a channel. It would be useful to have tests in this repo to test different types of persistent connections.

MDN docs on connection management: https://developer.mozilla.org/en-US/docs/Web/HTTP/Connection_management_in_HTTP_1.x
HAProxy post on pipelining and multiplexing: https://www.haproxy.com/blog/http-keep-alive-pipelining-multiplexing-and-connection-pooling

  • Tests Persistent Keep-Alive Connections (single request/response over same connection)
  • Http1.1 Pipelining (Multiple requests can be fired, but must be responded to in order)
  • Http2 Multiplexing (Ordering does not matter, same connection)
@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 9, 2023
@scrawfor99
Copy link
Collaborator

[Triage] Hi @cwperks, thanks for filing this issue. Looks great, will add the triaged label :).

@scrawfor99 scrawfor99 added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

2 participants