Fix error messaging from prometheus. #1029
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.4 #1029 +/- ##
=========================================
Coverage 98.26% 98.26%
- Complexity 3326 3329 +3
=========================================
Files 324 324
Lines 8399 8403 +4
Branches 553 554 +1
=========================================
+ Hits 8253 8257 +4
Misses 142 142
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vamsi-amazon
force-pushed
the
span-fix
branch
2 times, most recently
from
537534b
to
0f8ed02
Compare
|
Have you confirmed if 30 and 90 days' windowing is equivalent to month and quarter in Prometheus? It seems not in our span implementation. For example, |
|
Prometheus doesn't support month and quarter |
|
Are you suggesting to not push down in case month or quarter provided |
vamsi-amazon
force-pushed
the
span-fix
branch
from
0f8ed02
to
b365e4b
Compare
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vamsi-amazon
force-pushed
the
span-fix
branch
from
b365e4b
to
e74b331
Compare
vamsi-amazon
changed the title
Yes, either do it in post-processing or throw unsupported exception. Otherwise it would be confusing user. |
Yes. |
Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 4a9cef3)
* Fix `FLOAT` -> `DOUBLE` cast. (#1025) Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix error messaging from prometheus. (#1029) (#1037) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 4a9cef3) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> * Add `query` function as alternate syntax to `query_string` function (#1010) This maintains backwards compatibility with the v1 engine. * Update DATE and TIME functions to parse string input as datetime (#991) Add option to accept datetime like string in both TIME and DATE (eg. accept "1999-01-02 12:12:12" for both TIME and DATE. Strict check on date for testing for valid dates (eg. Don't accept Feb 30th as a valid date) and throws a SemanticCheckException. Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> * back quote fix (#1041) (#1050) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit d3bb902) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> * Catalog to Datasource changes (#1027) (#1049) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 3e30379) * Bump jackson to 2.14.0 (#1058) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 5a1adb2) * Add valueOf() to Expression (#1055) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Chen Dai <daichen@amazon.com> Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: GabeFernandez310 <64448015+GabeFernandez310@users.noreply.github.com> Co-authored-by: MitchellGale-BitQuill <104795536+MitchellGale-BitQuill@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: vamsi-amazon reddyvam@amazon.com
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.