Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Add Hour_Of_Day Function As An Alias Of Hour #1270

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9e67e5b from #1226

* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 9e67e5b)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 10, 2023 21:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #1270 (9e67e5b) into 2.5 (92b7681) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9e67e5b differs from pull request most recent head d3d25e0. Consider uploading reports for the commit d3d25e0 to get more accurate results

@@             Coverage Diff              @@
##                2.5    #1270      +/-   ##
============================================
- Coverage     98.35%   98.35%   -0.01%     
+ Complexity     3609     3605       -4     
============================================
  Files           346      344       -2     
  Lines          8939     8938       -1     
  Branches        562      562              
============================================
- Hits           8792     8791       -1     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...expression/function/RelevanceFunctionResolver.java 100.00% <ø> (ø)
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprDateValue.java 100.00% <100.00%> (ø)
...g/opensearch/sql/data/model/ExprDatetimeValue.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <100.00%> (ø)
.../opensearch/sql/data/model/ExprTimestampValue.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/data/model/ExprValueUtils.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo merged commit f7eb026 into 2.5 Jan 10, 2023
@github-actions github-actions bot deleted the backport/backport-1226-to-2.5 branch January 10, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants