Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #1337

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 3 comments · Fixed by #1384 or #1579
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #1337

dblock opened this issue Feb 14, 2023 · 3 comments · Fixed by #1384 or #1579
Assignees
@anirudha
Labels
maintenance Improves code quality, but not the product

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.
@dblock dblock mentioned this issue Feb 14, 2023
Closed
87 tasks
@Yury-Fridlyand Yury-Fridlyand added maintenance Improves code quality, but not the product and removed untriaged labels Feb 14, 2023
@derek-ho derek-ho mentioned this issue Feb 28, 2023
Merged
6 tasks
@dblock
Copy link
Member Author

dblock commented Mar 23, 2023

You have 19 maintainers in actual permissions, please work with admin to fix.
Screenshot 2023-03-23 at 11 07 56 AM

@dblock dblock reopened this Mar 23, 2023
@Yury-Fridlyand
Copy link
Collaborator

With most recent changes I can merge a PR with no approvals.

@penghuo penghuo removed the v2.7.0 label Apr 10, 2023
@Yury-Fridlyand Yury-Fridlyand mentioned this issue Apr 20, 2023
Merged
6 tasks
@anirudha anirudha self-assigned this Apr 25, 2023
@derek-ho derek-ho mentioned this issue Apr 25, 2023
Merged
6 tasks
@dblock
Copy link
Member Author

dblock commented Apr 27, 2023

Verified, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anirudha anirudha

Labels
maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

baseline repo groups derek-ho/sql
update codeowners and maintainers derek-ho/sql
5 participants
@anirudha @dblock @penghuo @Yury-Fridlyand @vamsi-amazon