Add time window and window assigner #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
43 tasks
Codecov Report
@@ Coverage Diff @@
## feature/maximus-m1 #950 +/- ##
========================================================
- Coverage 97.95% 95.22% -2.74%
- Complexity 3143 3153 +10
========================================================
Files 300 313 +13
Lines 7784 8463 +679
Branches 500 623 +123
========================================================
+ Hits 7625 8059 +434
- Misses 158 350 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
changed the title
6 tasks
penghuo
reviewed
Oct 26, 2022
...ain/java/org/opensearch/sql/planner/streaming/windowing/assigner/TumblingWindowAssigner.java
Show resolved
Hide resolved
penghuo
reviewed
Oct 26, 2022
...ain/java/org/opensearch/sql/planner/streaming/windowing/assigner/TumblingWindowAssigner.java
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Oct 26, 2022
...main/java/org/opensearch/sql/planner/streaming/windowing/assigner/SlidingWindowAssigner.java
Outdated
Show resolved
Hide resolved
penghuo
approved these changes
Oct 26, 2022
Signed-off-by: Chen Dai <daichen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Dai daichen@amazon.com
Description
Add window and window assigner interface along with tumbling and sliding window assigner implementation. This PR is only focus on core
WindowAssignerinterface. The future tasks in #954 will integrate it and other new windowing components with query plan operator.Window
A Window is a time interval which has start timestamp and end timestamp. For convenience, the end timestamp is exclusive and thus the window boundary is actually
[startTime, endTime-1].Window Assigner
A WindowAssigner identifies which window(s) the event belong. This is the first step and foundation of handling unbounded streaming data. As follows, an event may be assigned to a single window or multiple windows according to the windowing function. Here are a few example for common windowing approach.
Tumble window is fixed size without any overlap and start timestamp is aligned by mod window size.
Sliding window is fixed size but overlapped by slide size. The algorithm is referencing https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java#L70
Session windowing dynamic sized and defined by a given gap duration. It is useful for event representing user activity by analyzing user behavior within a session. Note that session window may cause window merging which will be supported in future as needed.
Issues Resolved
#951
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.