Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watermark generator #959

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Oct 24, 2022

Signed-off-by: Chen Dai daichen@amazon.com

Description

Watermark is a monotonically increasing timestamp of the oldest work not yet completed. The work can be any grouping operation, such as aggregate or join, that accumulate stream events to a table and maintain the state. In other words, watermark is the way of how we reason about the completeness of accumulated window state.

There are several aspects of watermark implementation, including watermark generation, watermark emit frequency and watermark propagation. This PR is focused on the watermark generation which has no dependency on how we integrate with query plan later.

What's covered in this PR is the common generate strategy: Bounded Out-Of-Order Watermark Generator which allows a fixed delay for disordered data.

Issues Resolved

#953

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the enhancement New feature or request label Oct 24, 2022
@dai-chen dai-chen self-assigned this Oct 24, 2022
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen force-pushed the maximus-m1/add-watermark-support branch from a01ab67 to 2ac0fb5 Compare October 27, 2022 21:05
Signed-off-by: Chen Dai <daichen@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #959 (98f55f6) into feature/maximus-m1 (91baab1) will decrease coverage by 35.19%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             feature/maximus-m1     #959       +/-   ##
=========================================================
- Coverage                 97.96%   62.76%   -35.20%     
=========================================================
  Files                       303       10      -293     
  Lines                      7805      658     -7147     
  Branches                    504      119      -385     
=========================================================
- Hits                       7646      413     -7233     
- Misses                      158      192       +34     
- Partials                      1       53       +52     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/opensearch/sql/expression/LiteralExpression.java
...opensearch/sql/expression/HighlightExpression.java
...ensearch/sql/planner/logical/LogicalHighlight.java
...on/window/aggregation/AggregateWindowFunction.java
.../opensearch/sql/opensearch/executor/Scheduler.java
.../org/opensearch/sql/data/model/ExprValueUtils.java
...l/expression/window/frame/PeerRowsWindowFrame.java
...arch/planner/logical/rule/MergeAggAndRelation.java
...ch/sql/prometheus/client/PrometheusClientImpl.java
...nsearch/sql/analysis/SelectExpressionAnalyzer.java
... and 303 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen marked this pull request as ready for review October 28, 2022 22:12
@dai-chen dai-chen requested a review from a team as a code owner October 28, 2022 22:12
@dai-chen dai-chen added this to the Maximus M1 - Phase 1 milestone Oct 31, 2022
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-chen dai-chen merged commit e8f3205 into opensearch-project:feature/maximus-m1 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants