Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a VideoView creates an unnecessary div #694

Open
nickgaray opened this issue Dec 2, 2022 · 1 comment
Open

Creating a VideoView creates an unnecessary div #694

nickgaray opened this issue Dec 2, 2022 · 1 comment

Comments

@nickgaray
Copy link
Collaborator

On Creating a video view, the base class View constructor is invoked, generating an id for the view, then calling init. Within init a div is created and this views id is assigned to it. This ends up creating an unnecessary div node that is not used in the presentation as VideoView creates a canvas and attaches it to the div with the given container id.

This makes having multiple videos create as many divs that are not used at all

@mdhsl
Copy link
Member

mdhsl commented Dec 2, 2022

This is a generic behavior into the Toolkit, not just for Video. The super class View create the div and provide it to the sub-classes.

The main idea is to have a user container and create an internal div with everything we want inside w/o modifying the user div (because of side effects).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants