Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of dist in repo #18

Closed
sebastianhaas opened this issue Jul 13, 2016 · 3 comments
Closed

Get rid of dist in repo #18

sebastianhaas opened this issue Jul 13, 2016 · 3 comments
Assignees
@sebastianhaas
Labels
infrastructure
Milestone
0.1.0-beta

Comments

@sebastianhaas
Copy link
Member

Its annoying. Take my PR #16 for instance. you can't properly browse changed files, everything is covered by this random dist stuff.

So I thought about having a npm prepublish hook that builds stuff before publish so it gets included inside the tgz for npm. The only problem here is that npm respects .gitignore for packaging, so I have to figure out how to do this.
@sebastianhaas sebastianhaas added this to the 0.0.1.alpha.2 milestone Jul 13, 2016
@sebastianhaas sebastianhaas self-assigned this Jul 13, 2016
@sebastianhaas
Copy link
Member Author

@matt-uib cc

@phonicscore phonicscore modified the milestones: 0.0.1-alpha.2, 0.1.0-beta Aug 23, 2016
@sebastianhaas sebastianhaas mentioned this issue Aug 24, 2016
Merged
@sebastianhaas
Copy link
Member Author

@matt-uib pls check #50 and merge so we can close this.
@bukaznik cc

@sebastianhaas
Copy link
Member Author

Fixed in #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianhaas sebastianhaas

Labels
infrastructure
Projects
None yet
Milestone
0.1.0-beta
Development

No branches or pull requests
2 participants
@sebastianhaas @phonicscore