Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2105357: Fix couple of issues which break CIM create wizard #1502

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Bug 2105357: Fix couple of issues which break CIM create wizard #1502

merged 1 commit into from
Jul 13, 2022

Conversation

rawagner
Copy link
Contributor

fixes:

  • call of useTranslation hook outside of component
  • remove execution of getLimitedFeatureSupportLevels which is not yet available in CIM
  • fix API range validation schema in CIM which does have dual stack yet

@rawagner rawagner requested review from a team as code owners July 13, 2022 12:58
celdrake
celdrake approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@celdrake celdrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issues in OCM too, thanks!

@ammont82 ammont82 self-requested a review July 13, 2022 13:38
@rawagner rawagner merged commit 1d661ac into openshift-assisted:master Jul 13, 2022
@rawagner rawagner changed the title Fix couple of issues which break CIM create wizard Bug 2105357: Fix couple of issues which break CIM create wizard Jul 18, 2022
celdrake pushed a commit to celdrake/assisted-ui-lib that referenced this pull request Jul 21, 2022
@rawagner @celdrake
Fix couple of issues which break CIM create wizard (openshift-assiste…
0f2e2bc 
…d#1502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celdrake celdrake celdrake approved these changes

@ammont82 ammont82 ammont82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rawagner @celdrake @ammont82