Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Semantics of Post-Build Tasks #352

Closed
stevekuznetsov opened this issue Jun 21, 2017 · 1 comment
Closed

Improve Semantics of Post-Build Tasks #352

stevekuznetsov opened this issue Jun 21, 2017 · 1 comment

Comments

@stevekuznetsov
Copy link
Contributor

Today, we run a number of post-build publishers. As only one org.jenkinsci.plugins.postbuildscript.PostBuildScript can be run as a publisher, we end up with a block of buildSteps of type hudson.tasks.Shell. This means that if we have a post-build flow like -- generate artifacts, retrieve artifacts, fetch systemd journals, deprovision cloud resources -- and one of the first hudson.tasks.Shell fails, the rest will not run. Although the larger org.jenkinsci.plugins.postbuildscript.PostBuildScript is set to run regardless of whether the job failed or not, the linear flow of hudson.tasks.Shell will exit early on any individual failure. We can try to address this by adding || true to our actions in these steps but in reality we just need a way to parameterize a named_shell_action so we don't always add set -o errexit. This way, failures will be silently ignored and all post-build tasks will run.

/cc @soltysh

@soltysh
Copy link

soltysh commented Jun 22, 2017

I need to familiarize myself with how this all machinery is working, but I'll try to hack something up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants