Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servicemesh/8-egress makes reference to now.httpbin.org in doc #612

Closed
komish opened this issue Nov 4, 2019 · 2 comments · Fixed by #610
Closed

servicemesh/8-egress makes reference to now.httpbin.org in doc #612

komish opened this issue Nov 4, 2019 · 2 comments · Fixed by #610

Comments

@komish
Copy link
Contributor

komish commented Nov 4, 2019

This workshop: https://learn.openshift.com/servicemesh/8-egress Makes a reference in the documentation text to now.httpbin.org, but I believe this was changed to worldclockapi.com

https://github.com/openshift-labs/learn-katacoda/blob/master/servicemesh/8-egress/2istioize-egress.md

Wanted to be sure before I submitted a PR to make the change or bundled it into #610
@BenHall
Copy link
Contributor

BenHall commented Nov 4, 2019

@komish

Thanks for pointing this out. Please add to #610. I'll check and merge this soon.

@komish
Copy link
Contributor Author

komish commented Nov 4, 2019

@BenHall Done and done. Thanks!

@komish komish mentioned this issue Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra commands, fix typos komish/learn-katacoda
2 participants
@BenHall @komish