Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub and Remote tasks settings #354

Merged
merged 2 commits into from Nov 5, 2021

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Nov 5, 2021

  • let user change the tekton hub base url via configmap setting
  • let user be able to disable all remote tasks via configmap setting

Part of https://issues.redhat.com/browse/SRVKP-1748

We let user specify another hub base url

partial fix on https://issues.redhat.com/browse/SRVKP-1748

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel
Copy link
Member Author

chmouel commented Nov 5, 2021

/retest

@codecov-commenter
Copy link

Codecov Report

Merging #354 (e931641) into main (38683ee) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   70.37%   70.49%   +0.12%     
==========================================
  Files          50       50              
  Lines        2562     2559       -3     
==========================================
+ Hits         1803     1804       +1     
+ Misses        581      579       -2     
+ Partials      178      176       -2     
Impacted Files Coverage Δ
pkg/hub/get.go 82.85% <100.00%> (+7.85%) ⬆️
pkg/pipelineascode/pipelineascode.go 60.37% <100.00%> (ø)
pkg/provider/bitbucketcloud/events.go 79.26% <100.00%> (ø)
pkg/consoleui/tektondashboard.go 66.66% <0.00%> (-8.34%) ⬇️
pkg/kubeinteraction/cleanups.go 69.23% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38683ee...e931641. Read the comment docs.

@chmouel chmouel merged commit e3327f0 into openshift-pipelines:main Nov 5, 2021
@chmouel chmouel deleted the allow-configuring-hub-url branch November 5, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants