Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor registry adapter code so that common registry functions don't overlap #180

Closed
dymurray opened this issue Jun 14, 2017 · 1 comment
Assignees

Comments

@dymurray
Copy link
Member

Right now we have to different registry adapters for RHCC and Dockerhub. This is due to the fact that Dockerhub expects an authorization token workflow and RHCC has a different search mechanism. We found that under the hood both adapters are doing some introspection on the manifest for each image, they just both vary on how to find that manifest.

Moving forward we would like to consolidate the code so that a common registry package exists which does introspection on the manifest to return the spec and then individual adapters for sourcing the images to grab the manifests from.

@rthallisey
Copy link
Contributor

Closing in favor of #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants