New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing dockerClient and dependency #227

Closed

eriknelson opened this issue Jun 23, 2017 · 1 comment

Contributor

eriknelson commented Jun 23, 2017

From discussion of #222

It's a vestige from when we pulled images before running then with oc run. I don't remember why we needed the pull in the first place, it's possible we never did. It's a use case entirely covered by the Pod pullPolicy. Huge bonus points if it means we can shed a dependency on docker entirely. We should definitely look into this, probably appropriate for an issue and follow up PR.

eriknelson mentioned this issue

Breakup all the Broker Clients into a clients pkg #222

Merged

shawn-hurley mentioned this issue

removing go-dockerclient #232

Merged

Contributor

shawn-hurley commented Jun 27, 2017

This was closed with #232

shawn-hurley closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment