Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registry config #49

Closed
eriknelson opened this issue Mar 23, 2017 · 3 comments
Closed

Improve registry config #49

eriknelson opened this issue Mar 23, 2017 · 3 comments
Assignees

Comments

@eriknelson
Copy link
Contributor

Registries are produced via factory, but the RegistryConfig struct is currently trying to serve the needs of each, which means values that are required to be present in the registry section of the config are not used for some concrete registry adapters.

Need to get better with the types here, i.e.

  registry:
    type: dev
    fields:
       user: hello
       url: foo.bar.com
@eriknelson
Copy link
Contributor Author

There are a finite number of adapter types; k8s uses Kind/Spec pattern to account for variable schemas, could use:

registry:
  kind: dockerhub
  spec:
     key: value
     dockerhub_specific_key: val

vs

registry:
  kind: otherkind
  spec:
     key: value
     otherkind_specific_key: val

@rthallisey
Copy link
Contributor

That would be a nice solution. We approaching the point where reducing the amount of yaml is imperative.

@shawn-hurley shawn-hurley self-assigned this Sep 15, 2017
@jmrodri jmrodri removed the postdemo label Sep 15, 2017
@rthallisey
Copy link
Contributor

#280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants